config --xx don't need env_file being parsed
#11025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #11025 +/- ##
==========================================
+ Coverage 57.39% 57.43% +0.03%
==========================================
Files 129 129
Lines 11229 11230 +1
==========================================
+ Hits 6445 6450 +5
+ Misses 4149 4147 -2
+ Partials 635 633 -2
☔ View full report in Codecov by Sentry. |
ndeloof
requested review from
a team,
nicksieger,
StefanScherer,
ulyssessouza,
glours,
milas and
laurazard
and removed request for
a team
ndeloof
force-pushed
the
SkipResolveEnvironment
branch
2 times, most recently
from
275130d to
4160bf2
Compare
glours
force-pushed
the
SkipResolveEnvironment
branch
from
4160bf2 to
8cc39bf
Compare
glours
approved these changes
Sep 21, 2023
go.mod
Outdated
| @@ -187,3 +187,5 @@ require ( | |||
|
|
|||
| // Override for e2e tests | |||
| replace github.com/cucumber/godog => github.com/laurazard/godog v0.0.0-20220922095256-4c4b17abdae7 | |||
|
|
|||
| replace github.com/compose-spec/compose-go => github.com/ndeloof/compose-go v1.2.4-0.20230920072217-f3748456c862 | |||
There was a problem hiding this comment.
compose-go is up to date in the main branch, this replace rule can be removed
ndeloof
force-pushed
the
SkipResolveEnvironment
branch
from
8cc39bf to
0dc3b43
Compare
Signed-off-by: Nicolas De Loof <[email protected]>
ndeloof
force-pushed
the
SkipResolveEnvironment
branch
from
0dc3b43 to
ab81db5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
use compose-spec/compose-go#460
Related issue
closes #10995
(not mandatory) A picture of a cute animal, if possible in relation to what you did